Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe Settings Validator check never stops #270

Closed
ghost opened this issue Aug 29, 2022 · 6 comments
Closed

Safe Settings Validator check never stops #270

ghost opened this issue Aug 29, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Aug 29, 2022

Problem Description

What is actually happening

Safe Settings Validator check always present never stops or cancels ( Starting NOP ... )

What is the expected behavior

to cancel at some point

Error output, if available


Context

On every pull request this safe settings validator check starts but never ends has been running : Starting NOP for Started 24d 23h 44m 47s ago, is it possible to disable this?

Are you using the hosted instance of probot/settings or running your own?

Self-Hosted Instance

If running your own instance, are you using it with github.com or GitHub Enterprise?

GitHub Enterprise

Version of probot/settings

not sure must be around 1-2 month old

Version of GitHub Enterprise

3.5.4

@ghost ghost added the bug Something isn't working label Aug 29, 2022
@svg153
Copy link
Contributor

svg153 commented Aug 29, 2022

Possibly related to #245. Could you confirm it?
A possible way to cancel it is to do what is commented here

@ghost
Copy link
Author

ghost commented Aug 29, 2022

@svg153 Thanks for the second link it seems that might be something that we can use.
But i think it might also be related to us having custom plugins and we might have removed/commented some code related to NOP.
I mainly wanted to know if its possible to disable this check run in general to not appear at all.

@decyjphr
Copy link
Collaborator

decyjphr commented Sep 1, 2022

Ok, so you don't want PR checks to be triggered in the first place?
One way would be not to send the checks to the Github App. You could change the GitHub app configuration and uncheck the Check run and Check suite events.
image

@ghost
Copy link
Author

ghost commented Sep 2, 2022

Will try to do that, thank you for the solutions both of you :)

@ghost ghost closed this as completed Sep 2, 2022
@martinm82
Copy link
Contributor

Would it be possible to report somehow all logs created by the validator to the pull request? We are as well facing the problem that the validator sometimes does not stop and we have no possibility to figure out what the real problem is. Probably by diving into the huge amount of the Probot logs would indicate the problem but for our users this is not possible.

Any ideas?

@ghost
Copy link
Author

ghost commented Nov 15, 2022

If you have all the GitHub App Settings correct, the only case where this happened to me is when you introduce modifications or custom plugins, if the NOP related lines of code have an issue then it will get stuck, or also in case you make a mistake in the YML and define some value like instead of saying "push" in the permission for teams you wrote "write". But this is only my personal experience.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants