Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New repositories not created during full-sync operation #709

Open
PendaGTP opened this issue Dec 11, 2024 · 0 comments · May be fixed by #710
Open

New repositories not created during full-sync operation #709

PendaGTP opened this issue Dec 11, 2024 · 0 comments · May be fixed by #710
Labels
bug Something isn't working

Comments

@PendaGTP
Copy link

Problem Description

When running safe-settings via GitHub Actions using the full-sync script, new repositories defined in the configuration are not being created, while all other settings synchronization works as expected.

Current vs Expected Behavior

Currently:

  • Full-sync runs successfully without errors
  • Existing repositories are properly synchronized
  • New repositories defined in config are not created

Expected:

  • New repositories should be created based on the configuration during full-sync

Technical Analysis

The issue stems from different code execution paths:

  1. Normal Operation (Working via webhook)

    • Event triggers syncSettingsSettings.syncSettings.updateRepos
    • Directly processes repositories without filtering
  2. Full-Sync (Not Working)

    • Process: syncInstallationsyncAllSettingsSettings.syncAllSettings.updateAll()
    • updateAll only processes existing repositories via eachRepositoryRepos (which use GET /installation/repositories to filter)
    • Missing: Check for repositories defined in config but not yet created

Environment

  • safe-settings: 2.1.24
  • Platform: github.com
  • Running on: Github Action (cron + manual trigger)
  • Using full-sync script

Related Issues

@PendaGTP PendaGTP added the bug Something isn't working label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant