Skip to content
This repository has been archived by the owner on Nov 1, 2017. It is now read-only.

Fix missing alt on images and icons #162

Merged
merged 2 commits into from
Dec 18, 2013
Merged

Conversation

jordanmccullough
Copy link
Contributor

Addresses the build failures of the script/cibuild.

@jordanmccullough
Copy link
Contributor Author

@gjtorikian Working on addressing all errors (missing alts, inaccessible resources, etc.) per the build failure since the introduction of HTML-Proofer.

I took a look at this PR that fixed relative paths, but seems something isn't playing nice with the relative paths of the images in the situation shown below. I can validate by inspecting the code, the paths of resources, and the page that the image is not missing. However, HTML-Proofer disagrees.

Let me know if you have ideas on this situation.

./_site/resources/videos/index.html: internal image assets/git-fringes.jpg does not exist

screen shot 2013-12-17 at 4 25 25 pm

@gjtorikian
Copy link

Ugh! Looks like the relative path magic is not set for images, only links. The short-term fixes are to just:

  1. Prepend ./ to the paths.
  2. Ignore it

Will definitely fix it in HTML::Proofer as soon as feasibly possible.

@afeld
Copy link
Contributor

afeld commented Dec 18, 2013

@gjtorikian Mind creating a placeholder issue, just so we can follow along?

@jordanmccullough
Copy link
Contributor Author

Reverse merge to update branch with (temporarily) disabled HTML-Proofer. Bringing in fixes thus far to mainline.

jordanmccullough pushed a commit that referenced this pull request Dec 18, 2013
Fix missing `alt` on images and icons
@jordanmccullough jordanmccullough merged commit 52e48e3 into gh-pages Dec 18, 2013
@jordanmccullough jordanmccullough deleted the content-proofer-fixes branch December 18, 2013 18:15
@gjtorikian gjtorikian restored the content-proofer-fixes branch December 25, 2013 19:12
@gjtorikian gjtorikian deleted the content-proofer-fixes branch December 25, 2013 19:12
@gjtorikian
Copy link

@jordanmccullough @aden A fix is in: gjtorikian/html-proofer#23

I'm working on speeding Proofer up as well. This repository has about 500 files, and builds are taking upwards of 10 minutes. Expect a 0.3.1 release 🔜 ish (within this year).

@jordanmccullough
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants