datasource: gitlab_projects

[oboukili]

Picked up the work of https://github.com/terraform-providers/terraform-provider-gitlab/pull/161, as this is a critical missing datasource.

• Made group_id optional
• Use terraform-plugin-sdk
• Method refactoring here and there

Most credit goes to @enieuw and the original PR contributors.

EDIT: I ended up redoing everything after all, the datasource now supports fully all group and project listProject APIs parameters exposed by the go-gitlab package.

[RyPeck]

Much appreciated - I currently use an external provider to retrieve the list of project_ids in a given group that I want to manage.

[oboukili]

I still do not understand why the acceptance tests I added detect a state drift, I guess I'll have to read the docs more thoroughly, any help would be appreciated!

[oboukili]

@roidelapluie I would definitely love having your input on datasources state drift resolution, I could not make it work.

EDIT: so I got it, it seems using explicit depends_on on a datasource does not prevent the related state object to exist, albeit empty, and therefore cause a false state drift detection. Anyways that's how I understand it, it was really informative :)

[oboukili]

Ready for review, this is essentially done.

[oboukili]

Pinging @ringods if I can do anything else to make this PR merged, please let me know, cheers :)

[ringods]

@oboukili FYI: https://github.com/terraform-providers/terraform-provider-gitlab/issues/133#issuecomment-607454848

[oboukili]

Hey there, any chance for a review?

[thapakazi]

What's required to get this merged ??

[ringods]

Hello @oboukili & @thapakazi, I became a maintainer of this provider not so long ago. I'm going over the pull requests backlog one by one.

Yesterday, I merged in another PR. While the PR build results were succesful, after merging, the commit on master failed. I reached out to the PR author to see if there is a correlation with the changes from the PR.

https://github.com/terraform-providers/terraform-provider-gitlab/runs/710870254

I hope you understand that I want to see the master branch have "green" tests first.

[thapakazi]

Totally understandable 👍 , anything we can help you up with?

[ringods]

@oboukili & @thapakazi the master branch is "green" again. I ran through this PR again.

May I ask to rebase your PR, meanwhile also squashing some commits?

The current list of commits is quite extensive and I'm not sure it adds to the clarity.

[ringods]

Tnx for your contribution. I will try to get this in a release later this week.

[oboukili]

Awesome, many thanks for the review @ringods !

[ringods]

Released in v2.9.0