Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab_project_variable: friendlier error when masked variable is invalid #380

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

armsnyder
Copy link
Collaborator

Closes #371

Rather than adding validation I intercepted the error.

Old error:

Error: POST https://gitlab.com/api/v4/projects/12345678/variables: 400 {message: {value: [is invalid]}}

New error:

Error: Invalid value for a masked variable. Check the masked variable requirements: https://docs.gitlab.com/ee/ci/variables/#masked-variable-requirements

@ghost ghost added the size/M label Aug 8, 2020
@michaelwooley
Copy link

Can't speak to the wider code quality, etc. However, the message/change looks like it should save some people a few headaches! Thanks for the turnaround.

@armsnyder
Copy link
Collaborator Author

@nicholasklick This one should ready to merge.

@armsnyder armsnyder merged commit f586dc3 into gitlabhq:master Sep 10, 2020
@armsnyder armsnyder deleted the 371-masked-validation branch September 10, 2020 00:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

gitlab_project_variable: Add masked checks
3 participants