Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log '🎉 You just saved x minutes of watching your code build.' if the build has failed. #1341

Closed
kittaakos opened this issue Mar 26, 2020 · 4 comments
Labels
meta: stale This issue/PR is stale and will be closed soon

Comments

@kittaakos
Copy link

info There appears to be trouble with your network connection. Retrying...
warning url-loader@1.1.2: Invalid bin field for "url-loader".
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.yarnpkg.com/rxjs/-/rxjs-6.5.4.tgz: ESOCKETTIMEDOUT".
info If you think this is a bug, please open a bug report with the information provided in "/workspace/theia/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

🍌 This task ran as part of a workspace prebuild.
🎉 You just saved 4 minutes of watching your code build.


[1] 1492
yarn run v1.22.4
$ theia start --plugins=local-dir:../../plugins ../.. --hostname=0.0.0.0
/bin/sh: 1: theia: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
gitpod /workspace/theia $ 

I opened Gitpod on this PR: eclipse-theia/theia#7422

@svenefftinge
Copy link
Member

svenefftinge commented Mar 26, 2020

Should rather be: You just saved 4 minutes of watching your build fail. 😄

@kittaakos
Copy link
Author

kittaakos commented Mar 26, 2020

Hmm, another PR has timed out. Can someone please verify?

Steps to reproduce:

  • Open any PR on Theia,
  • Click on the Gitpod button for the PR. (The Gitpod extension was installed to my browser, Brave, as a Chrome extension),
  • Wait until you see the Gitpod logo, then switch to any other browser tab so the Gitpod tab does not have the focus, it cannot requestAnimationFrame.
  • After 5-10 minutes or so, go back to the Gitpod tab.
  • My build has timed out again. 😕
gitpod /workspace/theia $  HISTFILE=/workspace/.gitpod/cmd-0 history -r; {
> [ -r /workspace/.prebuild-log-0 ] && cat /workspace/.prebuild-log-0; [ -r /workspace/.gitpod/prebuild-log-0 ] && cat /workspace/.gitpod/prebuild-log-0; true
> } && {
> jwm & yarn --cwd examples/browser start ../.. --hostname=0.0.0.0
> 
> }
gitpod /workspace/theia $ {
> yarn
> }; exit
yarn install v1.22.4
$ node-gyp install
gyp info it worked if it ends with ok
gyp info using node-gyp@5.0.7
gyp info using node@10.19.0 | linux | x64
gyp http GET https://nodejs.org/download/release/v10.19.0/node-v10.19.0-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v10.19.0/node-v10.19.0-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v10.19.0/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/release/v10.19.0/SHASUMS256.txt
10.19.0
gyp info ok 
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
warning url-loader@1.1.2: Invalid bin field for "url-loader".
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.yarnpkg.com/rxjs/-/rxjs-6.5.4.tgz: ESOCKETTIMEDOUT".
info If you think this is a bug, please open a bug report with the information provided in "/workspace/theia/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

🍌 This task ran as part of a workspace prebuild.
🎉 You just saved 5 minutes of watching your code build.


[1] 1479
yarn run v1.22.4
$ theia start --plugins=local-dir:../../plugins ../.. --hostname=0.0.0.0
/bin/sh: 1: theia: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
gitpod /workspace/theia $ 

@svenefftinge
Copy link
Member

This is due to : #1345 which is going to be fixed Monday morning (Europe)

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 4, 2020
@stale stale bot closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: stale This issue/PR is stale and will be closed soon
Projects
None yet
Development

No branches or pull requests

2 participants