-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image-builder: Use zstd
for a workspace image compression instead of gzip
#13861
Comments
@utam0k can you update the issue description to better describe how this will benefit users? For example, will users see time savings when pulling container images? If yes, what is the expected time savings? |
For now I've classified this change as "user quality of life". In other words, it does not seem like it is an essential change that we need "now". Is that right, @aledbf and @utam0k , that it's a nice to have? I'm just trying to make sure I understand the related motivation or "the why" for this issue. |
@kylos101 Thanks for your comment. |
yes, However, I expect implementation to be fairly straightforward. However, it depends on the containerd version(>=1.5), so it may be necessary to separate the case for self-hosted. |
👋 @utam0k no, thank you for asking, though. 😄 Please ignore this issue for now, let's leave in the inbox. That way, you can focus on groundwork that is either in-progress or scheduled. |
I agree with you👍 I was just going to write the issue as an idea as I don't think we should spend time on it now either. |
@kylos101 how does this benefit the end user? Shorter workspace startup times? |
Yes @atduarte , shorter workspace startup times on image build and pull, specifically. We'd have to change parts of our stack, though. Dazzle, image-builder-mk3, and registry-facade. I'm not sure about IPFS. There may be others. Related internal conversations [1][2] edit: 👇 General zstd goodness: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Is your feature request related to a problem? Please describe
Support for zstd123 compression, now we are using
gzip
, which is default forbuildkit
zstd is said to be much faster than gzip.
dazzle has already implemented gitpod-io/dazzle#58
AFAI, the implementation is simply to add
compression=zstd
to the following line. So it is worth a try.gitpod/components/image-builder-bob/pkg/builder/builder.go
Line 141 in 2c451bc
Describe the behaviour you'd like
Pull and push a workspace image with
zstd
.You should be able to check the manifest using oci-tool.
Describe alternatives you've considered
Additional context
docker (or rather moby) has not yet released a version that supports
zstd
. Implementation is complete.Footnotes
https://www.infoq.com/news/2022/09/amazon-gzip-zstd/ ↩
https://aws.amazon.com/blogs/containers/reducing-aws-fargate-startup-times-with-zstd-compressed-container-images/ ↩
https://www.slideshare.net/KoheiTokunaga/starting-up-containers-super-fast-with-lazy-pulling-of-images ↩
The text was updated successfully, but these errors were encountered: