-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hitting a breakpoints freezes the entire IDE. #709
Comments
Yes, websites with iframes run in a single loop. You need to open the preview in a new browser tab to get around that. |
Sorry, I don't think we can do anything about it as it is how browsers work. |
To open the preview in a browser tab click the icon on the top right. |
@akosyakov could you verify? |
From http://hassansin.github.io/shared-event-loop-among-same-origin-windows Because of it, I'm not sure that opening another window will help. It should still use the same event loop if it comes from the same origin. I think ideally we should run all theia iframes sandboxed somehow, i.e. on different origins, that they don't share event loop and other common state as cookies and local storage. |
@akosyakov see last paragraph:
|
@AlexTugarev but then we won't be able to communicate with that window? i.e. right now there is no way to detect iframe focus except installing a listener inside iframe and forward them to host window. I hope we will fix it in this way that focus given properly. |
So sounds like adding |
An issue in upstream: eclipse-theia/theia#5857 |
I believe this has been fixed 👍. |
@Alaboudi1 indeed thanks, good catch! 💯 The fix was merged 21 days ago and deployed as a hotfix 16 days ago. 🎉 |
I'm hitting this issue today, it doesn't seem fixed? |
It was reintroduced lately by some changes we made in Theia. Thanks for the PR you provided, we will put it into production ASAP. |
In production now |
Why hitting a
debugger;
statement in js code from the preview window also freezes the IDE? Is this the expected behavior?The text was updated successfully, but these errors were encountered: