Bad git executable

[haferburg]

This is the full message:

  Traceback (most recent call last):

    File "C:\Users\AHaferbu\.pyenv\pyenv-win\versions\3.9.6\lib\site-packages\git\__init__.py", line 83, in <module>
      refresh()
    File "C:\Users\AHaferbu\.pyenv\pyenv-win\versions\3.9.6\lib\site-packages\git\__init__.py", line 73, in refresh
      if not Git.refresh(path=path):
    File "C:\Users\AHaferbu\.pyenv\pyenv-win\versions\3.9.6\lib\site-packages\git\cmd.py", line 278, in refresh
      raise ImportError(err)

  ImportError: Bad git executable.

  The git executable must be specified in one of the following ways:

      - be included in your $PATH
      - be set via $GIT_PYTHON_GIT_EXECUTABLE
      - explicitly set via git.refresh()
 
  All git commands will error until this is rectified.

This error message could be much more helpful.

Which git executable is it trying to run?
Why? Where did it find that path? Is it using the PATH? Is it using GIT_PYTHON_GIT_EXECUTABLE?

[Byron]

Thanks for sharing - I agree.

The code for this is here, in case anyone wants to give it a shot:

GitPython/git/cmd.py

Lines 463 to 476 in 64ec0b1

	# Warn or raise exception if test failed.
	if not has_git:
	err = (
	dedent(
	"""\
	Bad git executable.
	The git executable must be specified in one of the following ways:
	- be included in your $PATH
	- be set via $%s
	- explicitly set via git.refresh(<full-path-to-git-executable>)
	"""
	)
	% cls._git_exec_env_var
	)

[EliahKagan]

This relates to the inconsistency discussed in #1815 (comment) and could be partially fixed by making initial refresh exception and logging messages include the path, as subsequent refresh messages have done since #1812. (I say "partially" because that would still not directly tell the user how that specific git executable path was set or discovered.)