Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple points of failures if path to the repository contains unicode #506

Open
yarikoptic opened this issue Sep 1, 2016 · 4 comments
Open

Comments

@yarikoptic
Copy link
Contributor

As demonstrated by setting TMPDIR=/tmp/ссылка in #505 . Although some failures might be confounded by having a symlinked portion of the path, but some looked really like failures due to unicode. Here is a direct link to one of the build logs: https://travis-ci.org/gitpython-developers/GitPython/jobs/156924625

@Byron Byron added this to the v2.0.9 - Bugfixes milestone Sep 11, 2016
@Byron
Copy link
Member

Byron commented Sep 11, 2016

A very nice test indeed !
Unfortunately it only seems to affect linux negatively, on OSX I cannot reproduce it with a line like TMPDIR=/tmp/ссылка nosetests git/test/test_commit.py.

I will hold off from that one for a moment though, even though I believe it should definitely be fixed.

@Byron Byron modified the milestones: v2.0.9 - Bugfixes, v2.0.10 - Bugfixes, v2.1.0 - proper windows support, v2.1.0 - better windows support, v2.1.1 - Bugfixes Oct 16, 2016
@Byron
Copy link
Member

Byron commented Oct 22, 2016

@yarikoptic Maybe you will have time to try this one again with the latest version. Recently there was a fix merged which might affect this issue.

@yarikoptic
Copy link
Contributor Author

pushed rebased ...

once again -- please use annotated and/or signed tags for releases ;-)

$> git describe upstream/master
0.3.6-537-g5149c80
changes on filesystem:                                                                                          
 git/ext/gitdb | 2 +-
2 15009.....................................:Sat 22 Oct 2016 10:50:38 AM EDT:.
(git)hopa:~deb/python-git[tmp-unicode-path]git
$> git describe --tags upstream/master 
2.1.0-3-g5149c80

@Byron
Copy link
Member

Byron commented Oct 22, 2016

Sorry, @yarikoptic ! Annotated tags I can do, forgot about that entirely. Would it help you if I would replace the existing one for 2.1.0 with an annotated one ?

@Byron Byron modified the milestones: v2.1.1 - Bugfixes, v2.1.2 - Bugfixes Dec 8, 2016
@Byron Byron modified the milestones: v2.1.2 - Bugfixes, v2.1.3 - Bugfixes Mar 8, 2017
@Byron Byron removed this from the v2.1.4 - Bugfixes milestone Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants