Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when linking to git://, ftp:// etc. URIs #119

Closed
akoeplinger opened this issue Oct 1, 2014 · 1 comment · Fixed by #120
Closed

Error when linking to git://, ftp:// etc. URIs #119

akoeplinger opened this issue Oct 1, 2014 · 1 comment · Fixed by #120

Comments

@akoeplinger
Copy link
Contributor

The following HTML produces validation errors:

<a href="git://github.com/mono/mono">Git</a>
<a href="ftp://ftp.example.com">FTP</a>
<a href="irc://irc.gimp.org/mono">IRC</a>
<a href="svn://svn.example.com">SVN</a>

../test.html: internally linking to git://github.com/mono/mono, which does not exist
../test.html: internally linking to ftp://ftp.example.com, which does not exist
../test.html: internally linking to irc://irc.gimp.org/mono, which does not exist
../test.html: internally linking to svn://svn.example.com, which does not exist

I tried passing in --href_ignore git, that changed nothing. I know that the proofer can't really validate the links, but shouldn't it just ignore them then, like it does with mailto: ?

@gjtorikian
Copy link
Owner

It should; thanks for the report. I'll probably have to add a skip for any protocol that's not HTTP(S), since you can put pretty much anything there (eg. github-mac://openRepo).

gjtorikian added a commit that referenced this issue Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants