Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: "Links test: fails on redirects if not following" #124

Closed
akoeplinger opened this issue Oct 16, 2014 · 2 comments · Fixed by #127
Closed

Failing test: "Links test: fails on redirects if not following" #124

akoeplinger opened this issue Oct 16, 2014 · 2 comments · Fixed by #127

Comments

@akoeplinger
Copy link
Contributor

Looks like something changed on the referenced URL, so the test fails now:

Failures:

  1) Links test fails on redirects if not following
     Failure/Error: output.should match /External link https:\/\/help.github.com\/changing-author-info\/ failed: 301 No error/
       expected "spec/html/proofer/fixtures/links/linkWithRedirect.html: External link http://timclem.wordpress.com/2012/03/01/mind-the-end-of-your-line/ failed: 301 No error\n" to match /External link https:\/\/help.github.com\/changing-author-info\/ failed: 301 No error/
     # ./spec/html/proofer/links_spec.rb:45:in `block (2 levels) in <top (required)>'
@doktorbro
Copy link

Looks like the test is not specific enough. Any of the 3 links inside the fixture can be expected. It has been passed purely by chance before.

@gjtorikian
Copy link
Owner

I know, I am being a super bad maintainer. Work has gotten hectic lately. I intend to fix this, merge in several PRs, and release a new gem 🔜 . 😟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants