file_ignore list only looks at first argument ?

[ahgittin]

is there a bug in the way multiple entries in the file_ignore list are handled? it looks like only the first item in the list is respected.

(then again it's entirely possible i've misunderstood how regex arrays are written in ruby -- apologies if so)

the issue is that this works to exclude ../catalog/.. items:

  :file_ignore => [ /.*\/(javadoc|catalog)\/.*/ ]

but this does not:

  :file_ignore => [ /.*\/javadoc\/.*/, /.*\/catalog\/.*/ ]

[gjtorikian]

Nope, it looks like file_ignore definitely iterates over each item:

html-proofer/lib/html/proofer.rb

Lines 234 to 240 in f2d3b57

	@options[:file_ignore].each do |pattern|
	if pattern.is_a? String
	return pattern == file
	elsif pattern.is_a? Regexp
	return pattern =~ file
	end
	end

Your regexp also looks right to me. I just noticed my test doesn't check for a list of ignore patterns, it only has a first item--so let me add a new test and see how that goes.

[gjtorikian]

@ahgittin Well, you were right! The array wasn't iterating for some reason. A fix is made in #153, and should be released in HTML-Proofer 2.0 🔜