Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about size of a downloaded page? #183

Closed
parkr opened this issue Feb 23, 2015 · 2 comments
Closed

Warn about size of a downloaded page? #183

parkr opened this issue Feb 23, 2015 · 2 comments

Comments

@parkr
Copy link
Contributor

parkr commented Feb 23, 2015

I have the feeling when checking links, HTML Proofer downloads the entire thing. If you link out to a big archive, therefore, then HTML Proofer has to download the whole archive. Are we checking the Content-Length header to ensure it's not too large? Are we limiting downloading to HTML pages only?

Thanks :)

@parkr
Copy link
Contributor Author

parkr commented Feb 23, 2015

Typhoeus timeout and connecttimeout options are crucial to happiness. The default is 300 seconds. Why.

@parkr parkr closed this as completed Feb 23, 2015
@gjtorikian
Copy link
Owner

I have the feeling when checking links, HTML Proofer downloads the entire thing.

FWIW it actually doesn't do this. First a HEAD request is made to see if a link is valid. If that fails, it moves on to making a GET. Some servers are not properly configured to HEAD, so it might fail as a false negative:

# Finally, we'll first make a HEAD request, rather than GETing all the contents.
# If the HEAD fails, we'll fall back to GET, as some servers are not configured
# for HEAD. If we've decided to check for hashes, we must do a GET--HEAD is
# not an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants