Do not check for favicon link on Redirect pages

[eksperimental]

I have raised an issue in the jekyll-rediret-from plugin project
jekyll/jekyll-redirect-from#63
regarding html-proof checking for the favicon link,
and a valid point is that those pages are not meant to be bookmarked, or visutalized for longer than a few seconds, or miliseconds in some cases,
so I think i wouldn't be a bad idea that the app doesn't complain about the favicon link missing if it's a pragma redirect page.

what do you guys think?

[gjtorikian]

One can simply ignore the file with file_ignore. I think it would be incredibly difficult to parse out from a file what is or is not a redirect page. Proofer would need to open ever file and check the meta tag to see if it is redirected or not. It's far easier for a human to just ignore the redirect files since, as you say, they're around for only a few moments.

[eksperimental]

but aren't you reading the page to diagnose that there's no favicon link in the first place?

[gjtorikian]

Sure, we're reading the page to check for a favicon. But to add a "check for meta tag, and if it exists, ignore the missing favicon" step to the process would slow the checks down. And adding a special --skip-favicon-for-redirects flags seems heavy-handed.

[eksperimental]

I see. no worries, I'm working on a bash script to weed out errors like these ones...
So you can still use it in CI.
I will share the link when published

[gjtorikian]

🆒