Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore attributes other than href #213

Closed
GarthDB opened this issue May 6, 2015 · 2 comments
Closed

Ignore attributes other than href #213

GarthDB opened this issue May 6, 2015 · 2 comments

Comments

@GarthDB
Copy link

GarthDB commented May 6, 2015

I'm getting errors on pages that haven't been published yet. Turns out it's the meta tag for the twitter card. I tried adding data-proofer-ignore to the meta tag, but it doesn't seem to ignore the content attribute.

<meta name="twitter:url" data-proofer-ignore content="http://example.com/soon-to-be-published-url" />
@doktorbro
Copy link

I’m already working on a global solution in #212.

But you also bring to our attention that data-proofer-ignore doesn’t work on Twitter’s meta elements. This is definitely a bug.

@GarthDB
Copy link
Author

GarthDB commented May 7, 2015

Excellent, I look forward to the pull request then.

Closing because it is a duplicate issue to #212

@GarthDB GarthDB closed this as completed May 7, 2015
@doktorbro doktorbro mentioned this issue May 26, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GarthDB @doktorbro