Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML-Proofer ignores 'data-proofer-ignore' #306

Closed
r-brown opened this issue Feb 16, 2016 · 3 comments
Closed

HTML-Proofer ignores 'data-proofer-ignore' #306

r-brown opened this issue Feb 16, 2016 · 3 comments

Comments

@r-brown
Copy link

r-brown commented Feb 16, 2016

Hello,

I'm trying to add 'data-proofer-ignore' attribute to the code below (Jekyll powered site):
https://github.com/Labs64/netlicensing.io/blob/gh-pages/_includes/google-search.html#L13

... but for some reason, this advice is being ignored by HTML-Proofer and I'm getting following:

- ./_site/blog/index.html
  *  Namespace prefix gcse is not defined (line 1)
  *  Tag gcse:search invalid (line 1)
htmlproof 2.6.4 | Error:  HTML-Proofer found 2 failures!

Those are used CLI attributes:
bundle exec htmlproof ./_site --verbose --check-html --ignore-script-embeds --href-ignore '/.*www.linkedin.com.*/,#'

What I'm missing here?

Best, Ready

@gjtorikian
Copy link
Owner

Thanks very much for the detailed report.

I've confirmed that this is a problem locally. I'll work on a fix for the next version, due out soon.

@r-brown
Copy link
Author

r-brown commented Feb 16, 2016

Thank you for picking up this issue.
May be you could extend the format, so also other attribute declarations will be taken into account
e.g.

<gcse:search data-proofer-ignore></gcse:search>
<gcse:search data-proofer-ignore=""></gcse:search>
<gcse:search data-proofer-ignore="true"></gcse:search>

@gjtorikian
Copy link
Owner

Closed by HTMLProofer 3.0: https://github.com/gjtorikian/html-proofer/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants