Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid URL failing validation #323

Closed
themaninthesuitcase opened this issue Mar 24, 2016 · 1 comment
Closed

Valid URL failing validation #323

themaninthesuitcase opened this issue Mar 24, 2016 · 1 comment
Assignees

Comments

@themaninthesuitcase
Copy link

I've added a link with colons in it to a draft post on a jekyll site. Currently this fails validation. This seems to be down to the colons.

The link in question is : https://overcast.fm/+CGRt2FEbw/1:17:15

I have researched it and it appears that these are valid characters in the position and the url works in Chrome, IE11 and Safari.

The error can be seen at this link : https://travis-ci.org/themaninthesuitcase/themaninthesuitcase.github.io/builds/118259215

- ./_site/2016/03/23/made-in-the-uk/index.html
  *  ​https://overcast.fm/+CGRt2FEbw/1:17:15 is an invalid URL (line 81)
- ./_site/index.html
  *  ​https://overcast.fm/+CGRt2FEbw/1:17:15 is an invalid URL (line 83)
htmlproofer 3.0.2 | Error:  HTML-Proofer found 2 failures!

Slightly off topic I am passing --disable-external so should this even be being validated or are external links still validated for format?

@gjtorikian gjtorikian self-assigned this Mar 24, 2016
@gjtorikian
Copy link
Owner

Slightly off topic I am passing --disable-external so should this even be being validated or are external links still validated for format

It shouldn't be validating external links. But I bet what's going on is that it in't recognizing URLs with :s as valid. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants