Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG 2.0 validation #366

Closed
Floppy opened this issue Dec 6, 2016 · 7 comments
Closed

WCAG 2.0 validation #366

Floppy opened this issue Dec 6, 2016 · 7 comments

Comments

@Floppy
Copy link
Contributor

Floppy commented Dec 6, 2016

I found http://tenon.io the other day for validating sites against accessibility guidelines, which is great. It would be amazing if html-proofer could do this as part of a CI workflow. There are guidelines on accessibility evaluation at https://www.w3.org/WAI/eval/Overview, but I don't know if there is a specific set of pass/fail type tests for this stuff - I'm far from an expert...

@Floppy
Copy link
Contributor Author

Floppy commented Dec 6, 2016

Just found https://github.com/accesslint/accesslint.rb, which might be able to take some of the load.

@Floppy
Copy link
Contributor Author

Floppy commented Dec 6, 2016

@Floppy
Copy link
Contributor Author

Floppy commented Dec 6, 2016

I could knock together a PR that uses accesslint.rb pretty quickly, but it depends on phantomjs being installed on the system. @gjtorikian is that the sort of thing you'd allow for optional checks? html-proofer is pretty pure, at the moment...

@gjtorikian
Copy link
Owner

I'll have to think about this a bit. On the one hand, I care about accessibility, and have hand-rolled or used other tooling to support this for CI. On the other hand, I added HTML validation to Proofer, and it ended up being a bad idea due to a bunch of false positives and work-arounds. I'd like to avoid that sort of situation here too, if it's possible. 😅

@Floppy
Copy link
Contributor Author

Floppy commented Dec 14, 2016

Yeah, it's not really a hard-and-fast validation, so the potential for false positives is high. I know what you mean...

@fulldecent
Copy link
Collaborator

I recommend closing the issue as out of project scope (recommended scope discussed at #422).

This is still a great idea and can be implemented as a third-party module (and mentioned here on a wiki) if anyone is interested to work on it.

@fulldecent
Copy link
Collaborator

Closing this issue now based on the approved project scope.

I do also care about accessibility. Please see the brand new wiki pages which discuss how to extend html-proofer.

https://github.com/gjtorikian/html-proofer/wiki

mailto-awesome in there is a simple example you can copy from to implement this additional check. I think a lot of people will want to use it and I would personally add it to my https://github.com/fulldecent/lightning-sites and https://github.com/fulldecent/html-website-template projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants