Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid hash check is wrong for other pages + aria-hidden not supported #367

Closed
jeznag opened this issue Dec 8, 2016 · 1 comment
Closed

Invalid hash check is wrong for other pages + aria-hidden not supported #367

jeznag opened this issue Dec 8, 2016 · 1 comment

Comments

@jeznag
Copy link

jeznag commented Dec 8, 2016

PR to follow
The hash link check will fail if the link is something like /about#Team (i.e. #Team on another page, About) because the code looks for the #Team ID on the current page rather than on the other page.

Also, alt text should not be checked if aria-hidden is "true".
@jeznag jeznag mentioned this issue Dec 8, 2016
Merged
@fulldecent
Copy link
Collaborator

PR is merged (the relevant parts at least). Recommending to close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fulldecent @jeznag