Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-proofer-ignore does not work on a parent element #370

Closed
klomontes opened this issue Dec 27, 2016 · 1 comment
Closed

data-proofer-ignore does not work on a parent element #370

klomontes opened this issue Dec 27, 2016 · 1 comment
Assignees

Comments

@klomontes
Copy link

I’m not sure if this is how it is intended to work or not but it seems like it should.

I have some scraped text loaded via liquid inside a <div> and I don’t want to check if links inside of it are valid or not since it is not the responsibility of the codebase I handle. I’ve put data-proofer-ignore on the parent div and htmlproofer still checks the links inside of it.

Is my assumption or implementation wrong? :)

@gjtorikian gjtorikian self-assigned this Dec 28, 2016
@gjtorikian
Copy link
Owner

Yeah, seems like parent ignores should trickle down too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants