Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRI/CORS check should ignore relative links #400

Closed
fulldecent opened this issue Mar 7, 2017 · 3 comments · Fixed by #412
Closed

SRI/CORS check should ignore relative links #400

fulldecent opened this issue Mar 7, 2017 · 3 comments · Fixed by #412
Assignees
@gjtorikian
Labels
help wanted

Comments

@fulldecent
Copy link
Collaborator

fulldecent commented Mar 7, 2017 •
edited
Loading

Test case

echo '<script src="local.js"></script>' > test.html
htmlproofer --check-sri --checks_to_ignore LinkCheck  .

Expected outcome

No errors.

Actual outcome

  • SRI and CORS not provided in: local.js (line 1)

Discussion

--check-sri should only be active for links containing //, or more specifically, links that contain a host component.

References: #388 #382
@fulldecent fulldecent mentioned this issue Mar 17, 2017
Closed
@fulldecent
Copy link
Collaborator Author

CSS check is not flagging local CSS files, this is good. JS is failing. Sorry, updated test case to show actual broken behavior.

@gjtorikian gjtorikian self-assigned this Mar 20, 2017
@fulldecent fulldecent mentioned this issue Mar 20, 2017
Closed
@fulldecent
Copy link
Collaborator Author

@ilyalyo Can you help with this one?

@ilyalyo
Copy link
Contributor

ilyalyo commented Mar 28, 2017

@fulldecent yes, I can.

@ilyalyo ilyalyo mentioned this issue Mar 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjtorikian gjtorikian

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SRI/CORS check should ignore relative links ilyalyo/html-proofer
3 participants
@gjtorikian @fulldecent @ilyalyo