Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counting error in HTML proofer. #466

Closed
robgarza opened this issue Jan 2, 2018 · 5 comments
Closed

Counting error in HTML proofer. #466

robgarza opened this issue Jan 2, 2018 · 5 comments

Comments

@robgarza
Copy link

robgarza commented Jan 2, 2018

There appears to be a reporting error. Below is the output from the HTML proofer. It ends with 256 failures, but I count 255 using both a spreadsheet and grep "*" in a terminal.

⚡️ Checking HTML
Running ["OpenGraphCheck", "HtmlCheck", "ImageCheck", "LinkCheck", "ScriptCheck", "MailToAwesome"] on ["BUILD"] on *.html...
Found 0 links in the cache...
Adding 417 links to the cache...
Removing 0 links from the cache...
Checking 417 external links...
Ran on 54 files!

@fulldecent
Copy link
Collaborator

Can you please reduce this to a minimal reproducible test case that includes an input file and output?

@fulldecent
Copy link
Collaborator

Closing this issue. @robgarza please make a smaller test case if you can, then I can reopen the issue.

@robgarza
Copy link
Author

robgarza commented Aug 2, 2018

@fulldecent , I just want to make sure I understand this correctly. I believe I am to create a branch of this site and remove all html that does not have anything to do with the errors that are being counted. Then, I should put the remaining html into one html file and use that as the input and the output file would be the resulting Travis-CI build, correct?

@fulldecent
Copy link
Collaborator

Minimal test case is probably a one-line html file plus a a htmlproofer command that is broken.

Or a new repository with one life of html and a .travis.yml which runs the html-proof command.

@robgarza
Copy link
Author

@fulldecent , this problem appears to have cleared up. I took a look at a recent build and the html-proofer counted the same number of failures that I did. This issue can stay closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants