Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant mandatory argument for "--as-links" option #504

Closed
geraldnguyen opened this issue Jan 15, 2019 · 1 comment
Closed

Redundant mandatory argument for "--as-links" option #504

geraldnguyen opened this issue Jan 15, 2019 · 1 comment

Comments

@geraldnguyen
Copy link

Hello.

The argument does not seem to do anything and the links to be checked are already available from the PATH argument

Examples:

/usr/local/lib/ruby/gems/2.6.0/bin/htmlproofer www.google.com,www.facebook.com --as-links 
Traceback (most recent call last):
	4: from /usr/local/lib/ruby/gems/2.6.0/bin/htmlproofer:23:in `<main>'
	3: from /usr/local/lib/ruby/gems/2.6.0/bin/htmlproofer:23:in `load'
	2: from /usr/local/lib/ruby/gems/2.6.0/gems/html-proofer-3.10.0/bin/htmlproofer:9:in `<top (required)>'
	1: from /usr/local/lib/ruby/gems/2.6.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
/usr/local/lib/ruby/gems/2.6.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:31:in `go': missing argument: --as-links (OptionParser::MissingArgument)
/usr/local/lib/ruby/gems/2.6.0/bin/htmlproofer www.google.com,www.facebook.com --as-links whatever
Running ["ImageCheck", "ScriptCheck", "LinkCheck"] on ["www.google.com", "www.facebook.com"] on *.html... 


Checking 2 external links...
HTML-Proofer finished successfully.

Is the -t option mistaken for --as-links' argument?

/usr/local/lib/ruby/gems/2.6.0/bin/htmlproofer www.google.com,www.facebook.com --as-links -t
Running ["ImageCheck", "ScriptCheck", "LinkCheck"] on ["www.google.com", "www.facebook.com"] on *.html... 


Checking 2 external links...
HTML-Proofer finished successfully.

Please let me know if you need additional info.

Regards,
Gerald

@gjtorikian
Copy link
Owner

Thanks for the report! There was a slight logic bug that needed correcting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants