Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from version 3.16.0 to 3.17.1 and all internal links fail to validate #601

Closed
stevecheckoway opened this issue Nov 23, 2020 · 2 comments

Comments

@stevecheckoway
Copy link
Contributor

I updated html-proofer from 3.16.0 to 3.17.1 and all internal links in my website failed to validate. After reverting to 3.16.0, everything is fine.

All of the errors look like

- _staging/teaching/cs668/2013-spring/syllabus.html
  *  internally linking to /css/old-teaching.css, which does not exist (line 1)
     <link rel="stylesheet" href="/css/old-teaching.css" type="text/css">

albeit with different files.

The files exist. E.g.,

$ file _staging/css/old-teaching.css
_staging/css/old-teaching.css: ASCII text, with very long lines

This happens for both link and a elements.

I'm running html-proofer via a Rake task.

task check: :build_for_deploy do
  require 'html-proofer'

  HTMLProofer.check_directory(
    STAGING,
    disable_external: true, # Change this when necessary
    check_html: true,
    internal_domains: ['checkoway.net'],
    validation: {
      report_invalid_tags: true,
      report_missing_names: true,
      report_script_embeds: true
    },
    cache: { timeframe: '1d' }
  ).run
end
@tisba
Copy link
Contributor

tisba commented Nov 23, 2020

I think this is a duplicate of #595

@stevecheckoway
Copy link
Contributor Author

@tisba You are correct! And 3.17.2 works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants