Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to directories without a trailing slash in 4.0.0 #718

Closed
brockfanning opened this issue Jul 11, 2022 · 1 comment · Fixed by #719
Closed

Linking to directories without a trailing slash in 4.0.0 #718

brockfanning opened this issue Jul 11, 2022 · 1 comment · Fixed by #719

Comments

@brockfanning
Copy link

Hello, it seems that version 4.0.0 is more strict about linking to directories without a trailing slash than 3.19.4 was. Whereas in 3.19.4 it allowed it when there was an "index.html" file in the directory, 4.0.0 is throwing an error. For example, see this failing test run upgrading 4.0.0 and then a passing test run after reverting to 3.19.4.

I'm not sure if this is a bug - maybe it was an intentional change? But I didn't see anything obvious about it in the changelog, so I thought I would post this here in case it's helpful. Feel free to close this if that change was intentional.

@gjtorikian
Copy link
Owner

Hey! Thanks so much for this issue report. This was definitely not intentional. And, unfortunately, the test which should have tested this feature was also broken in v3.x. 😅

4.0.1 corrects this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants