Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable internal/external cache altogether if not timeframe is specified #737

Closed
riccardoporreca opened this issue Jul 24, 2022 · 1 comment · Fixed by #736
Closed

Disable internal/external cache altogether if not timeframe is specified #737

riccardoporreca opened this issue Jul 24, 2022 · 1 comment · Fixed by #736

Comments

@riccardoporreca
Copy link
Collaborator

This follows up on #708, where support for separate timeframe for internal/external cache was introduced.

At the moment, if any of the two is not specified, the corresponding cache is still enabled but considered as always expired. Instead, one can disable the corresponding cache.
riccardoporreca added a commit to riccardoporreca/html-proofer that referenced this issue Jul 24, 2022
@riccardoporreca
Disable internal/external cache if no specific timeframe specified
6b821a3 
* Closes gjtorikian#737, as a follow-up of splitting the timeframe in gjtorikian#708.
* All cases are covered by tests.
@riccardoporreca
Copy link
Collaborator Author

A simple extension to support this is proposed in PR #736

@riccardoporreca riccardoporreca mentioned this issue Jul 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache fixes and improvements riccardoporreca/html-proofer
1 participant
@riccardoporreca