Empty mailto is generating undesired errors.

[ShoGinn]

With the new version 4.3.0 the parameter --ignore-empty-mailto doesn't seem to function.

Environment:

##[group]Run chabad360/htmlproofer@master
with:
  directory: ./public
  arguments: --allow-hash-href --ignore-empty-alt --disable-external --ignore-empty-mailto

Output:

htmlproofer 4.3.0
Running 3 checks (Scripts, Links, Images) in ["./public"] on *.html files...


Checking 412 internal links
Ran on 247 files!


For the Links check, the following failures were found:

* At ./public/post/1755/index.html:6:

  mailto:?subject=Farewell%20but%20not%20goodbye&body=https://example.com/post/1755/ contains no email address

Line in source:

<a href="mailto:?subject=Farewell%20but%20not%20goodbye&body=https://example.com/post/1755/" target=_blank rel=noopener class=share-btn-email aria-label=envelope><i class="fas fa-envelope"></i></a>

[gjtorikian]

Can you try

--ignore-empty-mailto=true

instead of just --ignore-empty-mailto?

Closing this because I think that will fix it, reopen if that's not the case.

[ShoGinn]

@gjtorikian you are right; adding an explicit =true does fix it..

Just weird the change ;)

[gjtorikian]

Yeah, lately the CLI parser has been causing a lot of problems. I noticed the library has not been updated since 2020, so it might be time to replace it with a more modern one.