4.3.1 Ignoring options

[plaindocs]

With 4.3.1 we're finding that options like --disable-external=true aren't working at all:

htmlproofer --ignore-files "/404/,/2013/,/2014/,/2015/,/2016/,/2017/,/videos/,/search\/index.html/" --allow-hash-href --enforce-https=false --ignore-missing-alt --disable-external=true docs/_build/html
Running 3 checks (Images, Links, Scripts) in ["docs/_build/html"] on *.html files...


Checking 2633 external links
Checking 4874 internal links

I've not dug in too deeply, but there is a little discussion here writethedocs/www#1774

Reverting to 4.2 does fix things.

[riccardoporreca]

@plaindocs, @gjtorikian, this is another instance of the CLI args issues, see #745 (comment) for a similar issue and relevant pointers, but you ultimately have to make sure to specify =true/false for all boolean options.

In your specific case:

--allow-hash-href=true --enforce-https=false --ignore-missing-alt=true --disable-external=true 

should do the job

[plaindocs]

Thanks @riccardoporreca ! <3

And thanks @gjtorikian for continued work on htmlproofer! <3