-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options validation breaking for booleans #773
Comments
I'm also hitting this issue when calling |
Shoot. Will revert and release a patch now. |
closed by #774 |
Thanks for the extremely quick response @gjtorikian 🎉 |
SkypLabs
added a commit
to SkypLabs/bsfl-slideshow
that referenced
this issue
Oct 9, 2022
Boolean arguments are broken at the moment: gjtorikian/html-proofer#773.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Setting some HTML proofer boolean flags on the command-line fails as follows:
Cause
The update validation logic added in 12a9409 stops boolean parameters from being changed. This is because Ruby treats
TrueClass
andFalseClass
separately, so the logic at line 103 oflib/html_proofer/configuration.rb
:will always raise a
TypeError
if the user provides afalse
for a parameter which defaults totrue
or vice-versa.The text was updated successfully, but these errors were encountered: