Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-proofer-ignore does not silence "Input contains noncharacter" #785

Closed
l0b0 opened this issue Dec 28, 2022 · 1 comment
Closed

data-proofer-ignore does not silence "Input contains noncharacter" #785

l0b0 opened this issue Dec 28, 2022 · 1 comment

Comments

@l0b0
Copy link

l0b0 commented Dec 28, 2022

Example:

- ./public/test/verify-html/consistent-fonts-in-firefox.html
  *  135:33: ERROR: Input contains noncharacter U+10FFFE.
— “<span data-proofer-ignore="">�</span>” — instead of an icon.</li>
                                ^ (line 135)

Is this intended? I've removed the offending section as a workaround.

Running htmlproofer 3.18.8.

Thank you for this project!

@gjtorikian
Copy link
Owner

I'm not sure I can do much about this, as html-proofer expects the incoming file(s) to be UTF-8 encoded. This character is marked as Supplementary Private Use Area-B—a "non-character"—and so its representation is undefined.

Unfortunately html-proofer is not designed to sanitize/clean up HTML text; that should be done prior to using this tool. To fix this, I imagine html-proofer would have to scrub these sorts of "unexpected code paths," which is a bit outside the scope of the project.

Feel free to reopen this issue if you disagree with a compelling usecase for why this should be preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants