Support for non-UTF-8 encoded URLs #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add a test? If not, just curious to know which file/URL was not working. |
|
Yes. Will do. The URL that tripped it was http://ben.balter.com/2014/09/29/source-disclosed-%E2%89%A0-open-source/. |
|
After spending too long trying to write a test for the two cases (https://github.com/gjtorikian/html-proofer/blob/38a2d9c519d01d2fed142961fa618d72d30492bd/spec/html/proofer/fixtures/links/utf8Link.html), I finally got it. I love |
gjtorikian
added a commit
that referenced
this pull request
Jan 28, 2015
Support for non-UTF-8 encoded URLs
|
Nice. Thanks for tackling that. Yeah, we use Addressable as part of Gman. Works wonders. |
stevemoser
added a commit
to stevemoser/benbalter.github.com
that referenced
this pull request
Jan 30, 2015
utf-8-urls has been merged into master gjtorikian/html-proofer#137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a conversion error that gets raised when running HTML-proofer on non-UTF-8 encoded URLs.