Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen up query check #243

Merged
merged 18 commits into from
Sep 8, 2015
Merged

Loosen up query check #243

merged 18 commits into from
Sep 8, 2015

Conversation

gjtorikian
Copy link
Owner

This loosens up the external URL checks for URLs with queries. For example:

<a href="https://github.com/contact?form%5Bsubject%5D=New+Assigned+Events">First</a>

<a href="https://github.com/contact?form%5Bsubject%5D=Organization+and+Team+Membership+APIs">Ignored</a>

<a href="https://github.com/contact#false?form%5Bsubject%5D=Organization+and+Team+Membership+APIs">Second, because of hash</a>

<a href="https://github.com/contact?form%5Bsubject%5D=Blah+and+blah+blah+APIs">Ignored</a>

It doesn't matter that contact?form has multiple values. The URL is essentially the same.

In this PR, we'll consider a URL with queries different if and only if it has different query parameters, not different query values.

gjtorikian added a commit that referenced this pull request Sep 8, 2015
@gjtorikian gjtorikian merged commit 31f4e27 into master Sep 8, 2015
@gjtorikian gjtorikian deleted the loosen-up-check branch September 8, 2015 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant