Clean up attr_accessor and handling of checks #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory this contains all the URLs actually iterated over, but in practice, it’s fairly useless.
This contains all the methods useful for iterating on a node
gjtorikian
added a commit
that referenced
this pull request
Jan 4, 2016
Clean up attr_accessor and handling of checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257. I didn't mean for this to be a huge rewrite, but some of the instantiations were so horrid, and so many needless ivars exposed, that it's taken a bit of time to hack through it all.
Closes #223.
Closes #256.