Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'return' with 'next' in block #34

Merged
merged 2 commits into from
Mar 24, 2014

Conversation

kansaichris
Copy link

Fixes a pretty nasty logic error that prevents HTML::Proofer from checking any links in a file once it finds one that should be ignored.

To Do

  • Write test(s) to prevent future regressions

@kansaichris
Copy link
Author

To be honest, I think that the other return statements in Links#run are suspect, too.

@gjtorikian
Copy link
Owner

Oh, shit! That's a big boo-boo. Are you working on a test, or do you want me to write one up real quick? Thanks!

@kansaichris
Copy link
Author

Are you working on a test, or do you want me to write one up real quick?

I haven't started working on a test yet—to be honest, your knowledge of the code base would probably make you more qualified to do it than me. 😄

@gjtorikian gjtorikian merged commit d6c5a5e into gjtorikian:master Mar 24, 2014
@kansaichris kansaichris deleted the fix-error-in-block branch March 24, 2014 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants