Add check_img_http to README #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documented on command line at https://github.com/gjtorikian/html-proofer/blob/a1f33c14b3e5523bc6ba4a4cef54869f57f98037/bin/htmlproofer#L24 but not in readme.
gjtorikian
requested changes
Jan 17, 2017
| @@ -219,6 +219,7 @@ The `HTMLProofer` constructor takes an optional hash of additional options: | |||
| | `check_favicon` | Enables the favicon checker. | `false` | | |||
| | `check_opengraph` | Enables the Open Graph checker. | `false` | | |||
| | `check_html` | Enables HTML validation errors from Nokogiri | `false` | | |||
| | `check_img_http` | Fails an image if it's marked as http | `false` | | |||
There was a problem hiding this comment.
You'll need to wrap this in http to get the test to pass. ✌️ (The test ensures the command line and README have the same documentation.)
|
OK, I'm silly for using the web editor. Will get to pass tests locally before adding more noise. |
|
Nah, you're good. The other failing test seems to be a fluke. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented on command line at
html-proofer/bin/htmlproofer
Line 24 in a1f33c1