Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle base without href #420

Merged
merged 2 commits into from
Apr 28, 2017
Merged

handle base without href #420

merged 2 commits into from
Apr 28, 2017

Conversation

mlinksva
Copy link
Contributor

<base> can have href and/or target attributes. Currently, href is not present obtains:

htmlproofer 3.6.0 | Error: Can't convert NilClass into String.

This PR allows <base> to not have an href attribute.

@gjtorikian
Copy link
Owner

Thank you!

@gjtorikian gjtorikian merged commit 6968943 into gjtorikian:master Apr 28, 2017
@mlinksva mlinksva deleted the baseless branch April 28, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlinksva @gjtorikian