Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop #431

Closed
wants to merge 3 commits into from
Closed

Rubocop #431

wants to merge 3 commits into from

Conversation

stephengroat
Copy link
Contributor

@stephengroat stephengroat commented May 9, 2017

to start with #423

i can easily make a .rubocop.yml file that disables errors like Block too long, Line too long, etc. let me know if that would be wanted

@stephengroat
Copy link
Contributor Author

I've looked through the error that I get on the default rake task. doesn't make sense to me, has the website changed?

@gjtorikian
Copy link
Owner

Thanks for this, especially the file renames!!!

has the website changed?

It's possible! Let me look into it.

@gjtorikian gjtorikian self-assigned this May 15, 2017
@stephengroat
Copy link
Contributor Author

i'll see if i can do some more cleaning and get rid of the errors that i know i caused by renaming files

rubocop.yml ignores some issues. also internal snake_case fixes
@stephengroat
Copy link
Contributor Author

did some more work on this. let me know what you think.

@gjtorikian
Copy link
Owner

Thank you very much!

I think I messed up the git rebase just now. Your commits are definitely on master, and your contributions have counted towards the project: https://github.com/gjtorikian/html-proofer/commits?author=stephengroat

But for some reason there's a merge conflict with this specific PR, and it's not reflecting as merged. I'm going to close this PR as stale. But again: I appreciate your contribution! Your changes are in! You have authorship credit! Just the UI here seems busted.

@gjtorikian gjtorikian closed this May 20, 2017
@fulldecent fulldecent mentioned this pull request May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants