Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use colorize gem #451

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Change to use colorize gem #451

merged 1 commit into from
Sep 22, 2017

Conversation

Floppy
Copy link
Contributor

@Floppy Floppy commented Sep 14, 2017

Colored is no longer maintained. Resolves #449, and will prevent a bunch of outdated dependency warnings for people using html-proofer.

There currently aren't any tests for the Log class, as far as I can see. Would you want some added in order to merge this?

colored is no longer maintained
@codecov-io
Copy link

codecov-io commented Sep 14, 2017

Codecov Report

Merging #451 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          27       27           
  Lines        1763     1763           
=======================================
  Hits         1737     1737           
  Misses         26       26
Impacted Files Coverage Δ
lib/html-proofer/log.rb 91.66% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c259f...8b5995b. Read the comment docs.

@gjtorikian
Copy link
Owner

Nah. Thanks for the change!

@gjtorikian gjtorikian merged commit 2ec2d11 into master Sep 22, 2017
@gjtorikian gjtorikian deleted the change-to-colorize branch September 22, 2017 19:51
@Floppy
Copy link
Contributor Author

Floppy commented Sep 25, 2017

And just like that, html-proofer no longer makes my DependencyCI builds fail! I'm so happy right now 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants