Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropping url.chomp('/') which cause 301s #462

Merged
merged 5 commits into from
Jan 5, 2018

Conversation

ldemailly
Copy link
Contributor

@ldemailly ldemailly commented Dec 7, 2017

And upgrading typhoeus

to solve #398 (comment)

@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #462 into master will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   98.53%   98.25%   -0.29%     
==========================================
  Files          27       27              
  Lines        1777     1775       -2     
==========================================
- Hits         1751     1744       -7     
- Misses         26       31       +5
Impacted Files Coverage Δ
lib/html-proofer/cache.rb 92.13% <100%> (-0.18%) ⬇️
spec/html-proofer/links_spec.rb 99.21% <100%> (ø) ⬆️
lib/html-proofer/url_validator.rb 93.98% <0%> (-3.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bff12...87a4778. Read the comment docs.

@Floppy
Copy link
Contributor

Floppy commented Dec 18, 2017

So do we think that in the Typheous version updated here, the extraneous trailing / has been fixed? Or should we still be using Addressable::URI#normalize, rather than just removing the existing normalization code?

@ldemailly
Copy link
Contributor Author

I left unescape_url because I wasn't sure of what it was doing exactly

from running without / chomping in CI I see no issue - or rather - it fixes a different bug where missing / causes a 301 timeout (some other bug in curl version in circleci or typhoeus) so for me it's been a improvement without which my CI build never passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants