Improve / Fix Example Code in README #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 27 27
Lines 1775 1775
=======================================
Hits 1744 1744
Misses 31 31Continue to review full report at Codecov.
|
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out I found that the example code for a custom check in the README does not actually run. It's mainly a word order typo.
I added the check for nil to the oktopost example, too because it's suspectible to the same issues - but that's optional and could be left out for conciseness sake.
If you want you can take over the .gitignore addition for JetBrains RubyMine IDE users, too. But that's just cosmetics.