Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more skippable rel types #484

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Add more skippable rel types #484

merged 2 commits into from
Aug 1, 2018

Conversation

gjtorikian
Copy link
Owner

Should close #481

@gjtorikian gjtorikian requested a review from Floppy as a code owner August 1, 2018 18:56
@gjtorikian gjtorikian merged commit e48d38a into master Aug 1, 2018
@gjtorikian gjtorikian deleted the favicon-skip-cors branch August 1, 2018 19:00
@codecov-io
Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #484 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   98.26%   98.27%   +<.01%     
==========================================
  Files          27       27              
  Lines        1789     1794       +5     
==========================================
+ Hits         1758     1763       +5     
  Misses         31       31
Impacted Files Coverage Δ
lib/html-proofer/check/links.rb 98.79% <100%> (+0.01%) ⬆️
lib/html-proofer.rb 100% <100%> (ø) ⬆️
spec/html-proofer/scripts_spec.rb 100% <100%> (ø) ⬆️
spec/html-proofer/favicon_spec.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c89079...f5caf78. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SRI and CORS should not report an error for favicon.
2 participants