Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't concat so much extra space #55

Merged
merged 1 commit into from
Jul 17, 2014
Merged

Don't concat so much extra space #55

merged 1 commit into from
Jul 17, 2014

Conversation

parkr
Copy link
Contributor

@parkr parkr commented Jul 17, 2014

screen shot 2014-07-17 at 12 46 16 am

vs

screen shot 2014-07-17 at 12 49 01 am

@doktorbro
Copy link

Much better.

@doktorbro
Copy link

We could make it optional --linespacing n default to 0.

@parkr
Copy link
Contributor Author

parkr commented Jul 17, 2014

I don't think I'd make it an option personally - what's thave value of being able to tweak it? What are the use cases for tweaking it?

@doktorbro
Copy link

What are the use cases for tweaking it?

If @gjtorikian needs 2 empty lines between messages (== 3 lines high messages), he would pass --lineheight 3.

I wouldn’t use this option, your current proposal is perfect for me (--lineheight 1).

@gjtorikian
Copy link
Owner

Less config is better, IMHO.

Fact: I usually just toss in a bunch of \n for my own use case, but surprisingly, people are using this project.

gjtorikian added a commit that referenced this pull request Jul 17, 2014
Don't concat so much extra space
@gjtorikian gjtorikian merged commit 9844b44 into gjtorikian:master Jul 17, 2014
@parkr parkr deleted the whitespace branch July 17, 2014 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants