Respect the ignore for favicons #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this the opposite of what we want? If the |
|
No. The fixture is: <html>
<head>
<link rel="icon" href="asdadaskdalsdk.png" data-proofer-ignore>
</head>
<body>
</body>
</html>For Proofer it should be the same as: <html>
<head>
</head>
<body>
</body>
</html>No favicon here. The test should fail. |
|
The favicon check make sure that at least one favicon is specified. The validation of link’s href attribute is not a part of the favicon checker. This is the job for the link checker. Further this is why the spec “fails for broken favicon” is not necessary for the favicon spec. |
gjtorikian
added a commit
that referenced
this pull request
Aug 18, 2014
Respect the ignore for favicons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user says “ignore this element”, we must obey. An ignored favicon doesn’t exist for us, so this test should fail, no matter how other attributes are.