Fix internal cache metadata check #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (External) urls can be added from several checks, hence we combine their corresponding metadata.
gjtorikian
force-pushed
the
feature/695-fix-internal-cache-metadata-check
branch
from
287bd2d
to
91a8a05
Compare
|
Thank you! I think the only thing missing in this PR was test cases. I independently created one(s) matching what you saw, saw them fail, and now see them passing in this PR. Thanks again. |
|
Oh hell, I force pushed to the wrong branch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695