Allow for empty alt attributes #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
added a commit
to GafferHQ/gafferhq.github.io
that referenced
this pull request
Jul 29, 2022
This feature was removed in `htmlproofer` 4.0. From the developer : > This was intentionally removed as part of the html-proofer 4.0 major release. It was removed because, over the years, it has provided more false positives than actual errors. HTML 5 engines in particular are much more forgiving of broken HTML, and so it logging the four or five small errors this check actual looked for was not worth the trouble of maintainence (I'm just one developer). I know of no other tools which duplicate the feature but there might be some W3C validators which run a similar check. We are much more interested in the link and image validation features, which continue to work. Also remove `--empty-alt-ignore`, which I believe is now the default behaviour, based on gjtorikian/html-proofer#717.
johnhaddon
added a commit
to GafferHQ/gafferhq.github.io
that referenced
this pull request
Jul 29, 2022
This feature was removed in `htmlproofer` 4.0. From the developer : > This was intentionally removed as part of the html-proofer 4.0 major release. It was removed because, over the years, it has provided more false positives than actual errors. HTML 5 engines in particular are much more forgiving of broken HTML, and so it logging the four or five small errors this check actual looked for was not worth the trouble of maintainence (I'm just one developer). I know of no other tools which duplicate the feature but there might be some W3C validators which run a similar check. We are much more interested in the link and image validation features, which continue to work. Also remove `--empty-alt-ignore`, which I believe is now the default behaviour, based on gjtorikian/html-proofer#717. And rename `--url-ignore` to `--ignore-urls`, because.
johnhaddon
added a commit
to GafferHQ/gafferhq.github.io
that referenced
this pull request
Sep 5, 2022
This feature was removed in `htmlproofer` 4.0. From the developer : > This was intentionally removed as part of the html-proofer 4.0 major release. It was removed because, over the years, it has provided more false positives than actual errors. HTML 5 engines in particular are much more forgiving of broken HTML, and so it logging the four or five small errors this check actual looked for was not worth the trouble of maintainence (I'm just one developer). I know of no other tools which duplicate the feature but there might be some W3C validators which run a similar check. We are much more interested in the link and image validation features, which continue to work. Also remove `--empty-alt-ignore`, which I believe is now the default behaviour, based on gjtorikian/html-proofer#717. And rename `--url-ignore` to `--ignore-urls`, because.
johnhaddon
added a commit
to GafferHQ/gafferhq.github.io
that referenced
this pull request
Sep 14, 2022
This feature was removed in `htmlproofer` 4.0. From the developer : > This was intentionally removed as part of the html-proofer 4.0 major release. It was removed because, over the years, it has provided more false positives than actual errors. HTML 5 engines in particular are much more forgiving of broken HTML, and so it logging the four or five small errors this check actual looked for was not worth the trouble of maintainence (I'm just one developer). I know of no other tools which duplicate the feature but there might be some W3C validators which run a similar check. We are much more interested in the link and image validation features, which continue to work. Also remove `--empty-alt-ignore`, which I believe is now the default behaviour, based on gjtorikian/html-proofer#717. And rename `--url-ignore` to `--ignore-urls`, because.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #228.
By default, html-proofer 4.0 will allow tags such as these:
per the HTML spec. However, a new option,
ignore_empty_alt, allows the user to override this and set them as failures. Missing alt tags (<img>) will remain as failures controllable byignore_missing_alt.