Speed up retrying of failed external link checks #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We retry external link checks in a few situations (e.g., to see if the server supports
GET
but notHEAD
). But we were performing these retries in a blocking manner. We now put the retries into theTyphoeus::Hydra
queue just like all the other requests, so they can be performed in parallel. This speeds up checking 62 links on a server that does not supportHEAD
from 20 seconds to 4 seconds on my machine.