Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial ms1 scan of 1 peak #269

Open
joewandy opened this issue Jul 6, 2023 · 1 comment
Open

Initial ms1 scan of 1 peak #269

joewandy opened this issue Jul 6, 2023 · 1 comment
Assignees
@joewandy
Labels
discussion Discuss issues encountered in the project

Comments

@joewandy
Copy link
Member

joewandy commented Jul 6, 2023

It appears that an initial MS1 scan of exactly 1 peak is always inserted at the start of a simulated run. I can't remember why we do this, but maybe it's something that can be removed now.

image
@joewandy joewandy added the discussion Discuss issues encountered in the project label Jul 6, 2023
@joewandy joewandy self-assigned this Jul 6, 2023
@joewandy joewandy changed the title Simulated scans are shifted by one Initial ms1 scan of 1 peak Jul 6, 2023
@mcbrider5002
Copy link
Collaborator

mcbrider5002 commented Oct 13, 2023 •
edited
Loading

@joewandy I think the matching is built around this behaviour too... I might need to change things a bit if it's not like this on the real machine...

EDIT: Actually, it might be self-correcting with the resynchronisation... I don't think we're running any non-simulated comparisons involving the resynchronisation and I can't see any reason why one would run on the real machine without it, so I guess it might be fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joewandy joewandy

Labels
discussion Discuss issues encountered in the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joewandy @mcbrider5002