Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-267: move arguments from pre-commit to config files #284

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Sep 26, 2024

Closes #267. The main advantage here is when running the given tool it will always work, rather than just via pre-commit. Previously requested in #230 (comment). Have used pyproject.toml where possible.

@paddyroddy paddyroddy self-assigned this Sep 26, 2024
@paddyroddy paddyroddy changed the title gh-267: move options from pre-commit config to pyproject.toml gh-267: move arguments from pre-commit to config files Sep 26, 2024
@paddyroddy paddyroddy added the infrastructure Project infrastructure: dev tools, packaging, etc. label Sep 27, 2024
@paddyroddy paddyroddy marked this pull request as ready for review September 27, 2024 16:24
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you moved it out already, should work too, no strong opinions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where possible add config options to pyproject.toml rather than .pre-commit-config.yaml
2 participants