Support i18n-tasks-use hints within JavaScript comment lines

[cbeckr]

i18n-tasks does not pick up i18n-tasks-use hints written in JavaScript, e.g.:

// i18n-tasks-use t('some.key')

The reason for this lies in RubyAstScanner's MAGIC_COMMENT_PREFIX, which looks as follows: /\A.\s*i18n-tasks-use\s+/.
The first dot is assuming a single comment character, so the line does not get picked up.

[glebm]

RubyAstScanner is only used to scan .rb files.
For .js and other files, the following is used instead:

i18n-tasks/lib/i18n/tasks/scanners/pattern_scanner.rb

Lines 16 to 22 in e2ffb33

	IGNORE_LINES = {
	'opal' => /^\s*#(?!\si18n-tasks-use)/,
	'haml' => /^\s*-\s*#(?!\si18n-tasks-use)/,
	'slim' => %r{^\s*(?:-#|/)(?!\si18n-tasks-use)},
	'coffee' => /^\s*#(?!\si18n-tasks-use)/,
	'erb' => /^\s*<%\s*#(?!\si18n-tasks-use)/
	}.freeze

PR welcome

[glebm]

Note that magic comments are actually supported but the call must match the following pattern:

i18n-tasks/lib/i18n/tasks/scanners/pattern_scanner.rb

Line 15 in e2ffb33

TRANSLATE_CALL_RE = /(?<=^|[^\w'\-.]|[^\w'\-]I18n\.|I18n\.)t(?:ranslate)?/

[zealot128]

Thanks for the tip. Because the IGNORE_LINES is frozen, i cannot modify IGNORE_LINES directly, but have to inherit from PatternScanner and reset it in an initializer.

class JsScanner < I18n::Tasks::Scanners::PatternScanner
  IGNORE_LINES = I18n::Tasks::Scanners::PatternScanner::IGNORE_LINES.merge(
    'js' => re=%r{^\s*// *(?!\si18n-tasks-use)}, 
    'ts' => re
  )
  def initialize(**args)
    super
    @ignore_lines_res = (config[:ignore_lines] || IGNORE_LINES).each_with_object({}) do |(ext, re), h|
      h[ext.to_s] = Regexp.new(re)
    end
  end
end
I18n::Tasks.add_scanner 'JsScanner', only: %w(*.js *.ts)

To make globs work in the use, one cannot use "*" but must simulate ruby in the comment:

// i18n-tasks-use t("js.feedback.behavior.options.#{key}")
$t("...")